Does Android's runOnUiThread call getView() in Adapters?

Execution: public View getView(int position, View convertView, ViewGroup parent) DisplayImage(coverFileNames. Get(position), imageView, position) Bear in mind that if getView is contained in the execution of DisplayImage You will have an infinite loop Since there is no infinite loop, then one of two scenarios can be true: DisplayImage executes something only ONCE and this something is trigerring getView ONCE something else is trigerring getView 2 is not true, since the only statement executed in getView is DisplayImage 1 is true DisplayImage executes one of the flavors of setImageDrawable once According to the source code of setImageDrawable View.requestLayout() and View. Invalidate are called View.requestLayout() will call ViewParent Interface's requestLayout() which according to the docs: Called when something has changed which has invalidated the layout of a child of this view parent.

This will schedule a layout pass of the view tree View. Invalidate will call ViewParent Interface's invalidateChild which might cause an invalidation on the ViewParent itself Therefore, it is safe to say that setting the image of an ImageView will cause an invalidation to itself. (Which is really the case and does not need to be proven anyway) Now Since this ImageView is a child of an Adapter interface, it is state of art that the Adapter's getView is called with the position of the exact view that contains this ImageView Finally Worry Not because getView in this case is equivelant to invalidate() and you surely want invalidate() to be called so that your images show up This is normal 1 MORE THING The bad performance of your application is not due to calling of the getView!

You should implement your DisplayImage correctly. Your class do not take into account any optimization. It is not the responsibility of the BaseAdapter Advice : I believe one big bottleneck is your queuePhoto function which is always calling the Clean function!

You are cleaning all the time! Your key is an ImageView! And you are comparing ImageView s all the time in a loop Just try to enhance your code and optimize it.

You should account for getView being called multiple of times.

Execution: public View getView(int position, View convertView, ViewGroup parent) DisplayImage(coverFileNames. Get(position), imageView, position) Bear in mind that if getView is contained in the execution of DisplayImage, You will have an infinite loop. Since there is no infinite loop, then one of two scenarios can be true: DisplayImage executes something only ONCE and this something is trigerring getView ONCE something else is trigerring getView.2 is not true, since the only statement executed in getView is DisplayImage 1 is true, DisplayImage executes one of the flavors of setImageDrawable once.

According to the source code of setImageDrawable View.requestLayout() and View. Invalidate are called.View.requestLayout() will call ViewParent Interface's requestLayout() which according to the docs: Called when something has changed which has invalidated the layout of a child of this view parent. This will schedule a layout pass of the view tree.View.

Invalidate will call ViewParent Interface's invalidateChild which might cause an invalidation on the ViewParent itself. Therefore, it is safe to say that setting the image of an ImageView will cause an invalidation to itself.(Which is really the case and does not need to be proven anyway) Now Since this ImageView is a child of an Adapter interface, it is state of art that the Adapter's getView is called with the position of the exact view that contains this ImageView Finally, Worry Not because getView in this case is equivelant to invalidate() and you surely want invalidate() to be called so that your images show up. This is normal.1 MORE THING The bad performance of your application is not due to calling of the getView!

You should implement your DisplayImage correctly. Your class do not take into account any optimization. It is not the responsibility of the BaseAdapter.

Advice: I believe one big bottleneck is your queuePhoto function which is always calling the Clean function! You are cleaning all the time! Your key is an ImageView!

And you are comparing ImageViews all the time in a loop Just try to enhance your code and optimize it. You should account for getView being called multiple of times.

It is not normal in this case. It's not invalidating all the Imageviews twice, it's invalidating all once and the selected ImageView a lot of unneccessary times. This causes really annoying lag, and performance issues because it needs to load images an unnecessary amount of times.

– Michell Bak Sep 6 at 9:32 ok I added some edits at the answer. The lag is your fault not the adapter's fault – Sherif Sep 6 at 10:30 Commenting out the Clean function changes nothing. It is still calling getView() too many times on the selected ImageView.

– Michell Bak Sep 6 at 10:47.

BitmapDisplayer is a Runnable that you run on the UI thread, and it calls methods on ImageView. These methods happen to generate layout requests, which will eventually cause getView() to be invoked.

I can see no problem in the code. I think its normal for adapterview to call getview when a item is selcted. Here is a link to another similar question that will explain further.

Custom listview adapter getView method being called multiple times, and in no coherent order Update Comment out the setImageResource line in DisplayImage and see if the number of calls to getView, for selected item, reduces to 2. Public void DisplayImage(String fileUrl, ImageView imageView, final int pos) { imageViews. Put(imageView, fileUrl); queuePhoto(fileUrl, activity, imageView, pos); // imageView.

SetImageResource(R.drawable. Noposterxl); // coment this line }.

The weird thing is that getview() is only being called when runOnUiThread is called. And what's even more weird is that it doesn't call getView() on all the images, only multiple times on the selected one. – Michell Bak Sep 3 at 11:46 If I just create the ImageViews normally in the getView() method, the method will only be called the correct number of times.

If I use the lazy loading class, it'll be called multiple times, which is slower and wrong. – Michell Bak Sep 3 at 11:50 Please check my updated question. – Michell Bak Sep 3 at 12:02 Sadly, no.It's still calling getView() the same exact number of times :-( – Michell Bak Sep 3 at 9:57.

This is not Weird issue, its normal to call getView method several times before showing the activity, this all about validating the views. To test it try to create normal list with just text, you will see every view is called twice.

No, every view is called once if I do it any other way. I've even showed you that in the question. My Gallery widget is not set to wrap content, so there's no need for it to call the items several times.

– Michell Bak Sep 6 at 6:29 but i've tested it before, as I said, mmm, build a custom ListView then override validation methods and print in it how many time validation is called. – MoshErsan Sep 6 at 6:45 I'm not using a ListView, as stated several times in the original question. And I've also tested it a lot of times, and it works just fine with everything else, except this class for lazy loading.

– Michell Bak Sep 6 at 8:17 whatever you are using, gallery is similar to listView – MoshErsan Sep 6 at 8:27 Please explain why what you're saying doesn't happen then. I've got multiple Gallery widgets that are working beautifully and that don't call getView() on the selected item multiple times, but they're not using lazy load. The issue only occurs when using that lazy load class, and my issue is that I don't see what's causing it (besides the runOnUiThread call).

Sorry, but what you're saying in this case is just inaccurate. – Michell Bak Sep 6 at 8:38.

I think it is the problem with listview height. If you provide some fixed height instead of wrap_content or fill_parent for listview height then I think it will work. Once check that.

I eventually made my own way to lazy load the images instead of using Fedor's code. This works all right. Thanks a lot for your help!

I cant really gove you an answer,but what I can give you is a way to a solution, that is you have to find the anglde that you relate to or peaks your interest. A good paper is one that people get drawn into because it reaches them ln some way.As for me WW11 to me, I think of the holocaust and the effect it had on the survivors, their families and those who stood by and did nothing until it was too late.